lkml.org 
[lkml]   [2010]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 05/15] nohz_task: Restart the tick when another task compete on the cpu
On Mon, Dec 20, 2010 at 04:53:21PM +0100, Peter Zijlstra wrote:
> On Mon, 2010-12-20 at 16:24 +0100, Frederic Weisbecker wrote:
> > +#ifdef CONFIG_NO_HZ_TASK
> > + /*
> > + * CHECKME:
> > + * Ideally, we need to check if the target has a nohz task
> > + * and only send the IPI if so. But there is nothing but
> > + * a racy way to do that. Or can we assume at that point
> > + * of the wake up that if cpu_has_nohz_task(cpu) is 0, then
> > + * it's ok, even if it has a task about to switch to nohz
> > + * task mode?
> > + */
> > + if (rq->nr_running == 2)
> > + smp_send_update_nohz_task_cpu(cpu);
> > +#endif
>
> This is the wrong place, use ttwu_activate(), since activate_task() is
> the thing that pokes at nr_running.

Ok, will do.

Thanks.


\
 
 \ /
  Last update: 2010-12-21 00:41    [W:0.143 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site