lkml.org 
[lkml]   [2010]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] hvc_dcc: Simplify put_chars()/get_chars() loops
    Date
    Casting and anding with 0xff is unnecessary in
    hvc_dcc_put_chars() since buf is already a char[].
    __dcc_get_char() can't return an int less than 0 since it only
    returns a char. Simplify the if statement in hvc_dcc_get_chars()
    to take this into account.

    Cc: Daniel Walker <dwalker@codeaurora.org>
    Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    ---
    drivers/char/hvc_dcc.c | 12 ++++--------
    1 files changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/char/hvc_dcc.c b/drivers/char/hvc_dcc.c
    index 155ec10..ad23cc8 100644
    --- a/drivers/char/hvc_dcc.c
    +++ b/drivers/char/hvc_dcc.c
    @@ -89,7 +89,7 @@ static int hvc_dcc_put_chars(uint32_t vt, const char *buf, int count)
    while (__dcc_getstatus() & DCC_STATUS_TX)
    cpu_relax();

    - __dcc_putchar((char)(buf[i] & 0xFF));
    + __dcc_putchar(buf[i]);
    }

    return count;
    @@ -99,15 +99,11 @@ static int hvc_dcc_get_chars(uint32_t vt, char *buf, int count)
    {
    int i;

    - for (i = 0; i < count; ++i) {
    - int c = -1;
    -
    + for (i = 0; i < count; ++i)
    if (__dcc_getstatus() & DCC_STATUS_RX)
    - c = __dcc_getchar();
    - if (c < 0)
    + buf[i] = __dcc_getchar();
    + else
    break;
    - buf[i] = c;
    - }

    return i;
    }
    --
    Sent by an employee of the Qualcomm Innovation Center, Inc.
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


    \
     
     \ /
      Last update: 2010-12-20 21:11    [W:0.024 / U:0.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site