lkml.org 
[lkml]   [2010]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Xen-devel] [PATCH 2/3] drivers/xen/balloon.c: Various balloon features and fixes
From
Date
On Mon, 2010-12-20 at 13:47 +0000, Daniel Kiper wrote:
> Features and fixes:
> - HVM mode is supported now,
> - migration from mod_timer() to schedule_delayed_work(),
> - removal of driver_pages (I do not have seen any
> references to it),
> - protect before CPU exhaust by event/x process during
> errors by adding some delays in scheduling next event,
> - some other minor fixes.
Each of those bullets should be a separate patch (or several if
appropriate). I didn't review most of the rest because it mixed so much
stuff together but a couple of minor things jumped out.

> -static void scrub_page(struct page *page)
> +static inline void scrub_page(struct page *page)

Is there some reason we need to override the compiler's decision here?
There is some discussion of the (over)use of inline in CodingStyle.

> static struct attribute_group balloon_info_group = {
> .name = "info",
> - .attrs = balloon_info_attrs,
> + .attrs = balloon_info_attrs
> };
>
> static struct sysdev_class balloon_sysdev_class = {
> - .name = BALLOON_CLASS_NAME,
> + .name = BALLOON_CLASS_NAME
> };

I don't think there is anything wrong with the existing style here.

Ian.




\
 
 \ /
  Last update: 2010-12-20 15:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site