lkml.org 
[lkml]   [2010]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/6] perf-probe: Fix line range description since a single file is allowed
    Date
    From: Franck Bui-Huu <fbuihuu@gmail.com>

    $ perf-probe -L sched.c

    is currently allowed but not documented.

    Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
    ---
    tools/perf/Documentation/perf-probe.txt | 2 +-
    tools/perf/util/probe-event.c | 13 ++++++++-----
    2 files changed, 9 insertions(+), 6 deletions(-)

    diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt
    index 62de1b7..562501f 100644
    --- a/tools/perf/Documentation/perf-probe.txt
    +++ b/tools/perf/Documentation/perf-probe.txt
    @@ -117,7 +117,7 @@ LINE SYNTAX
    -----------
    Line range is descripted by following syntax.

    - "FUNC[:RLN[+NUM|-RLN2]]|SRC:ALN[+NUM|-ALN2]"
    + "FUNC[:RLN[+NUM|-RLN2]]|SRC[:ALN[+NUM|-ALN2]]"

    FUNC specifies the function name of showing lines. 'RLN' is the start line
    number from function entry line, and 'RLN2' is the end line number. As same as
    diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
    index 3c92b92..8e5f5ff 100644
    --- a/tools/perf/util/probe-event.c
    +++ b/tools/perf/util/probe-event.c
    @@ -525,15 +525,18 @@ int show_available_vars(struct perf_probe_event *pevs __unused,
    }
    #endif

    +/*
    + * Stuff 'lr' according to the line range described by 'arg'.
    + * The line range syntax is described by:
    + *
    + * SRC[:SLN[+NUM|-ELN]]
    + * FNC[:SLN[+NUM|-ELN]]
    + */
    int parse_line_range_desc(const char *arg, struct line_range *lr)
    {
    const char *ptr;
    char *tmp;
    - /*
    - * <Syntax>
    - * SRC:SLN[+NUM|-ELN]
    - * FUNC[:SLN[+NUM|-ELN]]
    - */
    +
    ptr = strchr(arg, ':');
    if (ptr) {
    lr->start = (int)strtoul(ptr + 1, &tmp, 0);
    --
    1.7.3.2


    \
     
     \ /
      Last update: 2010-12-20 15:21    [W:0.026 / U:60.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site