lkml.org 
[lkml]   [2010]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mfd: tps6586x: Remove device ID check
    Date
    ... and convert it to a dev_info print at probe time.

    There are many variants of this chip with different values of VERSIONCRC.
    The set of values is large, and not useful to enumerate. All are SW
    compatible. The difference lies in default settings of the various power
    rails, and other similar differences. The driver, or clients of the
    driver, shouldn't be affected by this, since all rails should be
    programmed into the desired state in all cases for correct operation.

    Derived-from-code-by: Andrew Chew <achew@nvidia.com>
    Signed-off-by: Stephen Warren <swarren@nvidia.com>
    ---
    drivers/mfd/tps6586x.c | 6 +-----
    1 files changed, 1 insertions(+), 5 deletions(-)

    diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
    index b4931ab..cb482ba 100644
    --- a/drivers/mfd/tps6586x.c
    +++ b/drivers/mfd/tps6586x.c
    @@ -498,11 +498,7 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
    return -EIO;
    }

    - if ((ret != TPS658621A_VERSIONCRC) &&
    - (ret != TPS658621C_VERSIONCRC)) {
    - dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
    - return -ENODEV;
    - }
    + dev_info(&client->dev, "VERSIONCRC is %02x\n", ret);

    tps6586x = kzalloc(sizeof(struct tps6586x), GFP_KERNEL);
    if (tps6586x == NULL)
    --
    1.7.0.4
    nvpublic


    \
     
     \ /
      Last update: 2010-12-02 19:35    [W:3.809 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site