Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [RFC 5/5] truncate: Remove unnecessary page release | Date | Mon, 20 Dec 2010 11:21:52 +0900 (JST) |
| |
> This patch series changes remove_from_page_cache's page ref counting > rule. page cache ref count is decreased in remove_from_page_cache. > So we don't need call again in caller context. > > Cc: Nick Piggin <npiggin@suse.de> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: linux-mm@kvack.org > Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > --- > mm/truncate.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index 9ee5673..8decb93 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -114,7 +114,6 @@ truncate_complete_page(struct address_space *mapping, struct page *page) > * calls cleancache_put_page (and note page->mapping is now NULL) > */ > cleancache_flush_page(mapping, page); > - page_cache_release(page); /* pagecache ref */ > return 0;
Do we _always_ have stable page reference here? IOW, I can assume cleancache_flush_page() doesn't cause NULL deref?
| |