| Date | Sun, 19 Dec 2010 19:19:10 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 07/12] qla2xxx: Convert to host_lock less w/ interrupts disabled externally |
| |
On 12/19/2010 06:11 PM, Matthew Wilcox wrote: > I'm not sure this is the right direction to go. Now that Jeff's done > the pushdown and put in the compatibility macros, I don't think it makes > sense to do another partial transition on each driver. Much better to > take our time, analyse each driver thoroughly, and kill the DEF_SCSI_QCMD > in each driver without introducing IRQ_DISABLE_SCSI_QCMD.
Agreed... DEF_SCSI_QCMD was intended, as you note, to encourage a piecemeal, in-depth approach to cleaning up the rest of the drivers. Hopefully DEF_SCSI_QCMD removal means someone actually figured out [or already knew] the locking for a driver, and created the most appropriate patch, rather than another half-step.
Jeff
|