Messages in this thread | | | Subject | Re: [PATCH] regulator: Only notify voltage changes when they succeed | From | Liam Girdwood <> | Date | Fri, 17 Dec 2010 10:42:27 +0000 |
| |
On Thu, 2010-12-16 at 13:59 +0000, Mark Brown wrote: > Currently we notify a voltage change whenever we exit set_voltage(), > even if the change failed for some reason (eg, a constraints issue). > This shouldn't cause any substantial ill effects but is wasteful as > listeners get notified on noops. Fix this by moving the notification > into _do_set_voltage() and only notifying if we don't return an error. > > Reported-by: Saravana Kannan <skannan@codeaurora.org> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > drivers/regulator/core.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > Applied.
Thanks
Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
| |