lkml.org 
[lkml]   [2010]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator: Only notify voltage changes when they succeed
From
Date
On Thu, 2010-12-16 at 13:59 +0000, Mark Brown wrote:
> Currently we notify a voltage change whenever we exit set_voltage(),
> even if the change failed for some reason (eg, a constraints issue).
> This shouldn't cause any substantial ill effects but is wasteful as
> listeners get notified on noops. Fix this by moving the notification
> into _do_set_voltage() and only notifying if we don't return an error.
>
> Reported-by: Saravana Kannan <skannan@codeaurora.org>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/core.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk



\
 
 \ /
  Last update: 2010-12-17 11:45    [W:0.269 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site