Messages in this thread Patch in this message | | | From | Alexander Gordeev <> | Subject | [PATCHv6 08/16] pps: do not disable interrupts for idr operations | Date | Fri, 17 Dec 2010 22:54:32 +0300 |
| |
Now pps_idr_lock is never used in interrupt context so replace spin_lock_irq/spin_unlock_irq with plain spin_lock/spin_unlock.
Acked-by: Rodolfo Giometti <giometti@linux.it> Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su> --- drivers/pps/pps.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c index 79b4455..54964a5 100644 --- a/drivers/pps/pps.c +++ b/drivers/pps/pps.c @@ -239,9 +239,9 @@ static void pps_device_destruct(struct device *dev) /* release id here to protect others from using it while it's * still in use */ - spin_lock_irq(&pps_idr_lock); + spin_lock(&pps_idr_lock); idr_remove(&pps_idr, pps->id); - spin_unlock_irq(&pps_idr_lock); + spin_unlock(&pps_idr_lock); kfree(dev); kfree(pps); @@ -260,9 +260,9 @@ int pps_register_cdev(struct pps_device *pps) * After idr_get_new() calling the new source will be freely available * into the kernel. */ - spin_lock_irq(&pps_idr_lock); + spin_lock(&pps_idr_lock); err = idr_get_new(&pps_idr, pps, &pps->id); - spin_unlock_irq(&pps_idr_lock); + spin_unlock(&pps_idr_lock); if (err < 0) return err; @@ -302,9 +302,9 @@ del_cdev: cdev_del(&pps->cdev); free_idr: - spin_lock_irq(&pps_idr_lock); + spin_lock(&pps_idr_lock); idr_remove(&pps_idr, pps->id); - spin_unlock_irq(&pps_idr_lock); + spin_unlock(&pps_idr_lock); return err; } -- 1.7.2.3
| |