Messages in this thread | | | Date | Thu, 16 Dec 2010 22:28:35 -0800 | Subject | Re: [concept & "good taste" review] persistent store | From | Tony Luck <> |
| |
On Thu, Dec 16, 2010 at 5:57 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > Then I hit the > > /* Don't dump oopses to persistent store */ > if (reason == KMSG_DUMP_OOPS) > return; > > and I'm like "ok, this is just stupid". > > The _only_ valid reason for persistent storage is for things like > oopses that kill the machine.
Maybe I misunderstood what "KMSG_DUMP_OOPS" meant ... it looked to me like this code is used for non-fatal OOPsen - ones that will be logged to /var/log/messages.
You are right that the whole point of this is to save data from fatal errors ... if I'm not doing that, then I'm happy to change things until I achieve that goal.
-Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |