lkml.org 
[lkml]   [2010]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [concept & "good taste" review] persistent store
    From
    On Thu, Dec 16, 2010 at 5:57 PM, Linus Torvalds
    <torvalds@linux-foundation.org> wrote:
    > Then I hit the
    >
    >        /* Don't dump oopses to persistent store */
    >        if (reason == KMSG_DUMP_OOPS)
    >                return;
    >
    > and I'm like "ok, this is just stupid".
    >
    > The _only_ valid reason for persistent storage is for things like
    > oopses that kill the machine.

    Maybe I misunderstood what "KMSG_DUMP_OOPS" meant ... it
    looked to me like this code is used for non-fatal OOPsen - ones
    that will be logged to /var/log/messages.

    You are right that the whole point of this is to save data from
    fatal errors ... if I'm not doing that, then I'm happy to change
    things until I achieve that goal.

    -Tony
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-12-17 07:31    [W:0.021 / U:0.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site