lkml.org 
[lkml]   [2010]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/15] GFS2: fs/gfs2/glock.c: Use printf extension %pV
    Date
    From: Joe Perches <joe@perches.com>

    Using %pV reduces the number of printk calls and
    eliminates any possible message interleaving from
    other printk calls.

    Signed-off-by: Joe Perches <joe@perches.com>
    Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

    diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
    index 13155f6..a9b53a4 100644
    --- a/fs/gfs2/glock.c
    +++ b/fs/gfs2/glock.c
    @@ -951,17 +951,22 @@ int gfs2_glock_wait(struct gfs2_holder *gh)

    void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...)
    {
    + struct va_format vaf;
    va_list args;

    va_start(args, fmt);
    +
    if (seq) {
    struct gfs2_glock_iter *gi = seq->private;
    vsprintf(gi->string, fmt, args);
    seq_printf(seq, gi->string);
    } else {
    - printk(KERN_ERR " ");
    - vprintk(fmt, args);
    + vaf.fmt = fmt;
    + vaf.va = &args;
    +
    + printk(KERN_ERR " %pV", &vaf);
    }
    +
    va_end(args);
    }

    --
    1.7.3.3


    \
     
     \ /
      Last update: 2010-12-17 13:51    [W:0.040 / U:30.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site