Messages in this thread | | | Date | Thu, 16 Dec 2010 10:50:38 +0100 | From | Tejun Heo <> | Subject | Re: [patch 2/3] add new macros to make percpu readmostly section correctly align |
| |
Hello, Shaohua.
On 12/16/2010 06:56 AM, Shaohua Li wrote: >>>>> -#include <asm-generic/vmlinux.lds.h> >>>>> #include <asm/asm-offsets.h> >>>>> #include <asm/thread_info.h> >>>>> #include <asm/page_types.h> >>>>> #include <asm/cache.h> >>>>> +#include <asm-generic/vmlinux.lds.h> >>>>> #include <asm/boot.h> >>>> >>>> Why do we need this chunk? >>> the cache size is defined in cache.h, so I need move vmlinux.lds.h after >>> cache.h >> >> The right fix is to move the inclusion of cache.h to >> asm-generic/vmlinux.lds.h. A quick audit only found sparc that >> failed to guard non assembler stuff. > > with this, we need check every arch, at least doing a compile. I'm > afraid I can't, sorry.
Not being able to cross build every arch is okay but you at least need to make an effort to make things easily applicable to other archs and avoid adding subtle ugliness like the above. Please at least try to look at other arch codes and see how things can be made to work across different archs. Setting up cross compilers for the major archs, for example, sparc, power and ia64 isn't that difficult either.
Thanks.
-- tejun
| |