Messages in this thread | | | Date | Thu, 16 Dec 2010 16:02:02 -0800 | From | Greg KH <> | Subject | Re: [PATCH] USB: g_serial: Allow to override the default VID/PID |
| |
On Wed, Dec 15, 2010 at 08:57:47AM +0100, Jef Driesen wrote: > On 06/12/10 09:09, Robert Lukassen wrote: > >Yes, providing access to those module parameters was the original goal. I > >agree that my patch should be reverted and I'll try to come up with a method > >of accessing these values without violating the information hiding principles > >too much. I don't like accessing globals. > > Do I have to take any action to make sure the original commit [1] gets reverted? > > [1] 1ab83238740ff1e1773d5c13ecac43c60cf4aec4
It's now reverted.
thanks,
greg k-h
| |