[lkml]   [2010]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH V7 5/8] ptp: Added a brand new class driver for ptp clocks.
    On Thursday 16 December 2010, Richard Cochran wrote:
    > This patch adds an infrastructure for hardware clocks that implement
    > IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a
    > registration method to particular hardware clock drivers. Each clock is
    > presented as a standard POSIX clock.
    > The ancillary clock features are exposed in two different ways, via
    > the sysfs and by a character device.
    > Signed-off-by: Richard Cochran <>

    Looks fine to me, with one tiny comment:

    > +
    > +/* private globals */
    > +
    > +extern struct device_attribute ptp_dev_attrs[]; /* see ptp_sysfs.c */

    The declaration is in a C file, better move it into a header in order
    to make sure the definition matches the declaration.


     \ /
      Last update: 2010-12-16 16:59    [W:0.019 / U:13.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site