Messages in this thread | | | Date | Wed, 15 Dec 2010 05:44:14 -0800 | From | David Brown <> | Subject | Re: [PATCH v5 5/5] msm: add SMP support for msm |
| |
On Wed, Dec 15, 2010 at 12:35:18PM +0000, Catalin Marinas wrote: > On 14 December 2010 04:50, Jeff Ohlstein <johlstei@codeaurora.org> wrote: > > + outer_clean_range(__pa(&pen_release), __pa(&pen_release + 1)); > > + __asm__("sev"); > > + dsb(); > > What's the need for the dsb() here (one before SEV maybe)? > > Also, do we need to add a "memory" clobber to the SEV asm, not sure > whether the compiler would try to reorder the code.
It doesn't seem to, but it seems to me that it would be allowed to, so, I would think the "memory" clobber should be there.
David
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |