Messages in this thread | | | Date | Tue, 14 Dec 2010 22:46:46 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH v3 2/4] genirq: Inform handler about line sharing state |
| |
On Mon, 13 Dec 2010, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > chip_bus_lock(desc); > retval = __setup_irq(irq, desc, action); > chip_bus_sync_unlock(desc); > > - if (retval) > + if (retval) { > + if (desc->action && !desc->action->next) > + desc->irq_data.drv_status &= ~IRQS_SHARED;
This is redundant. IRQS_SHARED gets set in a code path where all checks are done already.
To make that more obvious we can set it right before
raw_spin_unlock_irqrestore(&desc->lock, flags);
conditionally on (shared).
That way we can also move the kfree out of the mutex locked section.
Thanks,
tglx
| |