lkml.org 
[lkml]   [2010]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cfq-iosched: don't check cfqg in choose_service_tree()
Date
Gui Jianfeng <guijianfeng@cn.fujitsu.com> writes:

> When cfq_choose_cfqg() is called in select_queue(), there must be at least one
> backlogged CFQ queue waiting for dispatching, hence there must be at least one
> backlogged CFQ group on service tree. So we never call choose_service_tree()
> with cfqg == NULL.

Further, if cfqg was NULL, cfq_choose_cfqg would have dereferenced a
NULL pointer and we wouldn't even get to choose_service_tree.

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>


\
 
 \ /
  Last update: 2010-12-14 17:59    [W:0.051 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site