Messages in this thread | | | Date | Tue, 14 Dec 2010 10:24:28 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v3] perf tools: Add symfs option for off-box analysis using specified tree |
| |
Em Thu, Dec 09, 2010 at 01:27:07PM -0700, David Ahern escreveu: > The symfs argument allows analysis of perf.data file using a locally > accessible filesystem tree with debug symbols - e.g., tree created > during image builds, sshfs mount, loop mounted KVM disk images, > USB keys, initrds, etc. Anything with an OS tree can be analyzed from > anywhere without the need to populate a local data store with > build-ids. > > Signed-off-by: David Ahern <daahern@cisco.com> > > v2 --> v3: handle symfs="/"
> @@ -2312,6 +2332,13 @@ int symbol__init(void) > symbol_conf.sym_list_str, "symbol") < 0) > goto out_free_comm_list; > > + /* a path to symbols of "/" is identical to "" > + * reset here for simplicity. > + */ > + if ((symbol_conf.symfs[0] == '/') && > + (symbol_conf.symfs[1] == '\0')) > + symbol_conf.symfs = ""; > + > symbol_conf.initialized = true; > return 0; >
Call me a nitpicker:
[acme@felicio ~]$ cat realpath.c #include <limits.h> #include <stdlib.h>
int main(int argc, char *argv[]) { char *resolved = realpath(argv[1], NULL);
puts(resolved); } [acme@felicio ~]$ make realpath cc realpath.c -o realpath [acme@felicio ~]$ ./realpath // / [acme@felicio ~]$ ./realpath //////////////// / [acme@felicio ~]$ ./realpath /./././ / [acme@felicio ~]$ ./realpath /..//. / [acme@felicio ~]$
I'll fix this up and merge, thanks!
- Arnaldo
| |