lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/4] sched: Cleanup pre_schedule_rt
    From: Yong Zhang <yong.zhang0@gmail.com>

    Since [commit 9a897c5a:
    sched: RT-balance, replace hooks with pre/post schedule and wakeup methods]
    we must call pre_schedule_rt if prev is rt task.
    So condition rt_task(prev) is always true and the 'unlikely' declaration is
    simply incorrect.

    Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    kernel/sched_rt.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
    index bea7d79..1ab66a2 100644
    --- a/kernel/sched_rt.c
    +++ b/kernel/sched_rt.c
    @@ -1474,7 +1474,7 @@ skip:
    static void pre_schedule_rt(struct rq *rq, struct task_struct *prev)
    {
    /* Try to pull RT tasks here if we lower this rq's prio */
    - if (unlikely(rt_task(prev)) && rq->rt.highest_prio.curr > prev->prio)
    + if (rq->rt.highest_prio.curr > prev->prio)
    pull_rt_task(rq);
    }

    --
    1.7.2.3



    \
     
     \ /
      Last update: 2010-12-14 02:31    [W:0.021 / U:89.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site