lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] mm: kswapd: Stop high-order balancing when any suitable zone is balanced
    On Fri, 10 Dec 2010, Mel Gorman wrote:

    > When the allocator enters its slow path, kswapd is woken up to balance the
    > node. It continues working until all zones within the node are balanced. For
    > order-0 allocations, this makes perfect sense but for higher orders it can
    > have unintended side-effects. If the zone sizes are imbalanced, kswapd may
    > reclaim heavily within a smaller zone discarding an excessive number of
    > pages. The user-visible behaviour is that kswapd is awake and reclaiming
    > even though plenty of pages are free from a suitable zone.
    >
    > This patch alters the "balance" logic for high-order reclaim allowing kswapd
    > to stop if any suitable zone becomes balanced to reduce the number of pages
    > it reclaims from other zones. kswapd still tries to ensure that order-0
    > watermarks for all zones are met before sleeping.
    >
    > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    > Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
    > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

    Started reviewing before I saw this series.

    Reviewed-by: Eric B Munson <emunson@mgebm.net>
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-12-13 20:37    [W:4.797 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site