Messages in this thread | | | Date | Mon, 13 Dec 2010 07:39:24 -0700 | From | "David S. Ahern" <> | Subject | Re: [PATCH 1/2] perf tools: Add reference timestamp to perf header |
| |
On 12/12/10 13:16, Frederic Weisbecker wrote:
>> int perf_session__create_kernel_maps(struct perf_session *self) >> { >> int ret = machine__create_kernel_maps(&self->host_machine); >> @@ -167,6 +190,9 @@ struct perf_session *perf_session__new(const char *filename, int mode, bool forc >> */ >> if (perf_session__create_kernel_maps(self) < 0) >> goto out_delete; >> + >> + if (perf_session__create_ref_time(self) < 0) >> + goto out_delete; > > So, it does record it anytime?
Simplest to always add it the header as it does no harm if not used. To make it conditional means adding an input parameter to perf_session__new() and then updating all the callers.
Is the preference to make it conditional?
David
> >> } >> >> perf_session__update_sample_type(self); > > > Other than that, looks good! > -- > To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |