[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] [81/223] xen: don't bother to stop other cpus on shutdown/reboot
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    From: Jeremy Fitzhardinge <>

    commit 31e323cca9d5c8afd372976c35a5d46192f540d1 upstream.

    Xen will shoot all the VCPUs when we do a shutdown hypercall, so there's
    no need to do it manually.

    In any case it will fail because all the IPI irqs have been pulled
    down by this point, so the cross-CPU calls will simply hang forever.

    Until change 76fac077db6b34e2c6383a7b4f3f4f7b7d06d8ce the function calls
    were not synchronously waited for, so this wasn't apparent. However after
    that change the calls became synchronous leading to a hang on shutdown
    on multi-VCPU guests.

    Signed-off-by: Jeremy Fitzhardinge <>
    Cc: Alok Kataria <>
    Signed-off-by: Greg Kroah-Hartman <>
    Signed-off-by: Andi Kleen <>

    arch/x86/xen/enlighten.c | 4 ----
    1 file changed, 4 deletions(-)

    Index: linux/arch/x86/xen/enlighten.c
    --- linux.orig/arch/x86/xen/enlighten.c
    +++ linux/arch/x86/xen/enlighten.c
    @@ -1000,10 +1000,6 @@ static void xen_reboot(int reason)
    struct sched_shutdown r = { .reason = reason };

    -#ifdef CONFIG_SMP
    - stop_other_cpus();
    if (HYPERVISOR_sched_op(SCHEDOP_shutdown, &r))

     \ /
      Last update: 2010-12-13 01:19    [W:0.018 / U:6.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site