[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] [213/223] rds: Integer overflow in RDS cmsg handling
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    From: Dan Rosenberg <>

    commit 218854af84038d828a32f061858b1902ed2beec6 upstream.

    In rds_cmsg_rdma_args(), the user-provided args->nr_local value is
    restricted to less than UINT_MAX. This seems to need a tighter upper
    bound, since the calculation of total iov_size can overflow, resulting
    in a small sock_kmalloc() allocation. This would probably just result
    in walking off the heap and crashing when calling rds_rdma_pages() with
    a high count value. If it somehow doesn't crash here, then memory
    corruption could occur soon after.

    Signed-off-by: Dan Rosenberg <>
    Signed-off-by: David S. Miller <>
    Signed-off-by: Greg Kroah-Hartman <>
    Signed-off-by: Andi Kleen <>

    net/rds/rdma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux/net/rds/rdma.c
    --- linux.orig/net/rds/rdma.c
    +++ linux/net/rds/rdma.c
    @@ -474,7 +474,7 @@ static struct rds_rdma_op *rds_rdma_prep
    goto out;

    - if (args->nr_local > (u64)UINT_MAX) {
    + if (args->nr_local > UIO_MAXIOV) {
    ret = -EMSGSIZE;
    goto out;

     \ /
      Last update: 2010-12-13 01:13    [W:0.018 / U:37.852 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site