lkml.org 
[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [207/223] can-bcm: fix minor heap overflow
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Oliver Hartkopp <socketcan@hartkopp.net>

    commit 0597d1b99fcfc2c0eada09a698f85ed413d4ba84 upstream.

    On 64-bit platforms the ASCII representation of a pointer may be up to 17
    bytes long. This patch increases the length of the buffer accordingly.

    http://marc.info/?l=linux-netdev&m=128872251418192&w=2

    Reported-by: Dan Rosenberg <drosenberg@vsecurity.com>
    Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    CC: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/can/bcm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux/net/can/bcm.c
    ===================================================================
    --- linux.orig/net/can/bcm.c
    +++ linux/net/can/bcm.c
    @@ -125,7 +125,7 @@ struct bcm_sock {
    struct list_head tx_ops;
    unsigned long dropped_usr_msgs;
    struct proc_dir_entry *bcm_proc_read;
    - char procname [9]; /* pointer printed in ASCII with \0 */
    + char procname [20]; /* pointer printed in ASCII with \0 */
    };

    static inline struct bcm_sock *bcm_sk(const struct sock *sk)

    \
     
     \ /
      Last update: 2010-12-13 01:13    [W:2.632 / U:9.672 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site