lkml.org 
[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [189/223] Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Greg Kroah-Hartman <gregkh@suse.de>

    commit 4d7bc388b44e42a1feafa35e50eef4f24d6ca59d upstream.

    They should be writable by root, not readable.
    Doh, stupid me with the wrong flags.

    Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/staging/samsung-laptop/samsung-laptop.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux/drivers/staging/samsung-laptop/samsung-laptop.c
    ===================================================================
    --- linux.orig/drivers/staging/samsung-laptop/samsung-laptop.c
    +++ linux/drivers/staging/samsung-laptop/samsung-laptop.c
    @@ -356,7 +356,7 @@ static ssize_t set_silent_state(struct d
    }
    return count;
    }
    -static DEVICE_ATTR(silent, S_IRUSR | S_IRUGO,
    +static DEVICE_ATTR(silent, S_IWUSR | S_IRUGO,
    get_silent_state, set_silent_state);



    \
     
     \ /
      Last update: 2010-12-13 00:57    [W:3.529 / U:0.064 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site