[lkml]   [2010]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] load fbcon from drm_kms_helper
    Kconfig says fbcon is required by drm_kms_helper.  If radeon, fbcon,
    and drm_kms_helper are all modules, radeon is auto loaded (by PCI id?),
    drm_kms_helper is loaded because of the module dependency, but fbcon
    isn't loaded leaving the console unusable. Since fbcon is required
    and there isn't an explicit module dependency, request the module
    to be loaded from drm_kms_helper.

    Signed-off-by: David Fries <>
    Cc: David Airlie <>
    This solves compiling CONFIG_FB=m and being left with a blank screen
    because the radeon module is automatically loaded, but fbcon isn't.
    If radeon had to be manually loaded, then it would be the user's fault for
    not loading fbcon as well, but as radeon is being loaded automatically,
    there isn't much a user can do from console to even fix it. More bug
    details from here,

    Does this look like a reasonable solution? Should it bother checking
    find_module first?

    drivers/gpu/drm/drm_fb_helper.c | 21 +++++++++++++++++++++
    1 files changed, 21 insertions(+), 0 deletions(-)

    diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
    index d2849e4..dd1e726 100644
    --- a/drivers/gpu/drm/drm_fb_helper.c
    +++ b/drivers/gpu/drm/drm_fb_helper.c
    @@ -1530,3 +1530,24 @@ bool drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper)

    + * but the module doesn't depend on any fb console symbols. At least
    + * attempt to load fbcon to avoid leaving the system without a usable console.
    + */
    +static int __init drm_fb_helper_modinit(void)
    + const char *namue = "fbcon";
    + struct module *fbcon;
    + mutex_lock(&module_mutex);
    + fbcon = find_module(name);
    + mutex_unlock(&module_mutex);
    + if (!fbcon)
    + request_module_nowait(name);
    + return 0;

     \ /
      Last update: 2010-12-11 22:15    [W:0.028 / U:1.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site