lkml.org 
[lkml]   [2010]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/16] x86: Remove custom apic->cpu_to_logical_apicid() implementations
    Hello, Thomas.

    On 12/09/2010 10:28 PM, Thomas Gleixner wrote:
    >> After the previous patch, apic->cpu_to_logical_apicid() is no longer
    >> used. The callback will be repurposed. Remove all the custom
    >
    > That's a very bad idea. You remove the callbacks from the esoteric
    > platforms, but you keep the other implementation in the tree.
    >
    > It's not longer used now, so remove all incarnations and get rid of
    > all those useless = NULL initializations at the same time. Then
    > implement a new callback with a different name.

    Yeah, that would be cleaner. I wasn't very sure about clearing
    unimplemented apic ops. Currently the rule seems to be always setting
    them to NULL and I didn't want to re-do that with a new callback.

    > It's slightly more work and code churn, but it makes the change
    > entirely clear. It'd be also nice to annotate in the function name
    > that this is 32bit only or even make it 32bit dependent if it's not
    > too much ifdeffery

    Yeah, sure, if the silly NULL assignments aren't necessary, I don't
    think it would be much more churn anyway.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2010-12-10 12:15    [W:2.702 / U:1.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site