Messages in this thread | | | Date | Fri, 10 Dec 2010 13:21:08 -0800 | From | Jesse Barnes <> | Subject | Re: [PATCH v2] PCI: Disable ASPM if BIOS asks us to |
| |
On Fri, 10 Dec 2010 21:18:49 +0000 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Fri, Dec 10, 2010 at 01:07:19PM -0800, Jesse Barnes wrote: > > On Mon, 6 Dec 2010 14:00:56 -0500 > > Matthew Garrett <mjg@redhat.com> wrote: > > > > > We currently refuse to touch the ASPM registers if the BIOS tells us that > > > ASPM isn't supported. This can cause problems if the BIOS has (for any > > > reason) enabled ASPM on some devices anyway. Change the code such that we > > > explicitly clear ASPM if the FADT indicates that ASPM isn't supported, > > > and make sure we tidy up appropriately on device removal in order to deal > > > with the hotplug case. If ASPM is disabled because the BIOS doesn't hand > > > over control then we won't touch the registers. > > > > > > Signed-off-by: Matthew Garrett <mjg@redhat.com> > > > --- > > > > > > > Applied to linux-next, thanks. > > Agh. It seems I sent the wrong version - there's a missing e in > pci_clear_aspm. Can you fix that up, or should I resend?
I'll fix it up (was just doing the build test now), thanks.
-- Jesse Barnes, Intel Open Source Technology Center
| |