Messages in this thread | | | Date | Fri, 10 Dec 2010 10:44:02 -0800 | From | Chris Wright <> | Subject | Re: [PATCH] intel-iommu: Fix use after release during device attach |
| |
* Jan Kiszka (jan.kiszka@siemens.com) wrote: > >>> --- a/drivers/pci/intel-iommu.c > >>> +++ b/drivers/pci/intel-iommu.c > >>> @@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct > >>> iommu_domain *domain, > >>> > >>> pte = dmar_domain->pgd; > >>> if (dma_pte_present(pte)) { > >>> - free_pgtable_page(dmar_domain->pgd); > >>> dmar_domain->pgd = (struct dma_pte *) > >>> phys_to_virt(dma_pte_addr(pte));
While here, might as well remove the unnecessary cast.
> >>> + free_pgtable_page(pte); > >>> } > >>> dmar_domain->agaw--; > >>> } > >> > >> Reviewed-by: Sheng Yang <sheng@linux.intel.com>
Acked-by: Chris Wright <chrisw@sous-sol.org>
> >> CC iommu mailing list and David. > > > > Ping... > > > > I think this fix also qualifies for stable (.35 and .36). > > > > Still not merged?
David, do you plan to pick this one up?
thanks, -chris
| |