lkml.org 
[lkml]   [2010]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC][PATCH 02/10] mm: Remove likely() from mapping_unevictable()
    Date
    Joe Perches <joe@perches.com> writes:
    > It'd be better to use
    >
    > if (!mapping)
    > return 0;
    > return test_bit(AS_UNEVICTABLE, &mapping->flags);
    >
    > to avoid the unnecessary !!

    How about

    return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags);

    instead...?

    -miles

    --
    Yossarian was moved very deeply by the absolute simplicity of
    this clause of Catch-22 and let out a respectful whistle.
    "That's some catch, that Catch-22," he observed.
    "It's the best there is," Doc Daneeka agreed.


    \
     
     \ /
      Last update: 2010-12-10 09:11    [W:0.021 / U:31.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site