Messages in this thread | | | From | Miles Bader <> | Subject | Re: [RFC][PATCH 02/10] mm: Remove likely() from mapping_unevictable() | Date | Fri, 10 Dec 2010 17:08:05 +0900 |
| |
Joe Perches <joe@perches.com> writes: > It'd be better to use > > if (!mapping) > return 0; > return test_bit(AS_UNEVICTABLE, &mapping->flags); > > to avoid the unnecessary !!
How about
return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags);
instead...?
-miles
-- Yossarian was moved very deeply by the absolute simplicity of this clause of Catch-22 and let out a respectful whistle. "That's some catch, that Catch-22," he observed. "It's the best there is," Doc Daneeka agreed.
| |