Messages in this thread | | | Date | Fri, 10 Dec 2010 10:04:00 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/8] staging: ft1000: Convert char device to debugfs. |
| |
On Fri, Dec 10, 2010 at 12:35:33PM -0500, Dave Jones wrote: > On Thu, Dec 09, 2010 at 01:43:36PM +0300, Dan Carpenter wrote: > > > + file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir, > > ^^^^^^^ > > > + NULL, &ft1000fops); > > > > Don't make this world writeable. > > we should probably make checkpatch catch this. > > > > > Exporting world writable sysfs/debugfs files is usually a bad thing. > Warn about it. > > Signed-off-by: Dave Jones <davej@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
| |