Messages in this thread | | | Subject | Re: [RFC PATCH V2 5/5] Add TX zero copy in macvtap | From | Eric Dumazet <> | Date | Fri, 10 Dec 2010 17:55:06 +0100 |
| |
Le vendredi 10 décembre 2010 à 08:25 -0800, Shirley Ma a écrit : > On Fri, 2010-12-10 at 11:27 +0100, Eric Dumazet wrote: > > You could make one atomic_add() outside of the loop, and factorize > > many > > things... > > > > atomic_add(len, &skb->sk->sk_wmem_alloc); > > skb->data_len += len; > > skb->len += len; > > skb->truesize += len; > > while (len) { > > ... > > } > > Yep, thanks, will update it!
Also take a look at skb_fill_page_desc() helper, and maybe skb_add_rx_frag() too.
The atomic op should be factorized for sure, but other adds might be done by helpers to keep code short.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |