lkml.org 
[lkml]   [2010]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs during transfer
Hi,

thanks for the submission. It has some issues, though:

On Thu, Dec 09, 2010 at 03:34:55PM -0500, Ben Gardiner wrote:

> + nsecs =
> +#if defined(CONFIG_SLOWER_SPI_GPIO)
> + !cs->nsecs ? cs->nsecs : 100;
> +#else
> + 100;
> +#endif

This coding style is very hard to read and gains nothing for it. Also,
slower_spi should rather be a per-device than a config option.

Kind regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-12-10 12:49    [W:0.074 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site