Messages in this thread | | | Date | Wed, 1 Dec 2010 20:56:38 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] add netdev led trigger |
| |
Hi!
> > Please be consistent with rest of kernel... > > There seem to be several ways this is done in existing sysfs drivers, > and most aren't documented yet in Documentation/ABI.
Greg is official sysfs maintainer.
> 1. "0" and "1"
This should do the trick.
> 2. "enable" and "disable" > 3. "enabled" and "disabled" > 4. "enable" and "disable" when writing, but "enabled" and "disabled" > when read back > > Some require trailing "\n", others make it optional. > > Which is the One True Way? Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |