Messages in this thread | | | Date | Wed, 01 Dec 2010 11:35:33 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir |
| |
On 12/01/2010 11:17 AM, Linus Torvalds wrote:
> So this is a TOTALLY UNTESTED trivial patch that just adds another > callback. Does this work? I dunno. But I get the feeling that instead > of having NFS work around the odd semantics that don't actually match > what NFS wants, introducing a new callback with much simpler semantics > would be simpler for everybody, and avoid the need for subtle code.
Surely somebody can have just looked up the page and gotten a reference count, right before your ->freepage call is invoked?
CPU A CPU B
look up page grab refcount ->freepage
use contents of page
Am I overlooking something obvious?
-- All rights reversed
| |