lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PULL] fixes for tidspbridge 2.6.37-rc1
    On Tue, Nov 09, 2010 at 11:53:29PM +0200, Felipe Contreras wrote:
    > On Tue, Nov 9, 2010 at 7:58 PM, Greg KH <greg@kroah.com> wrote:
    > > If it is easy to revert and push later, then the "revert just this
    > > piece" should be done now.
    > >
    > > Seriously, I'm getting very confused here, and am very annoyed by the
    > > whole thing.
    >
    > With good reason.
    >
    > > Here's what I don't like:
    > >  - the original driver didn't even seem to work properly
    >
    > It _was_ working properly, when it was a separate branch, but the
    > merge to staging wasn't done correctly, so it has never worked there.

    Well, blame the people who sent it to me then :)

    > >  - people sent me patches they never tested and broke things even worse
    >
    > Part of the blame goes to TI. Even if you have the hardware, it's not
    > straightforward to test this. I have struggled to improve the
    > situation on user-space with the gst-dsp and dsp-tools projects, which
    > btw have not received support from TI, but apparently they were not
    > used to test this (neither was the "official" solution from TI which
    > is much harder to set up).
    >
    > >  - some people have no respect for the omap maintainers and what they
    > >    think about things, or even basic knowledge of the kernel
    > >    development cycle.
    >
    > I don't think this is the case. The opinion of the OMAP maintainers is
    > valuable in order to cleanup the mess that is this driver. But _first_
    > it has to work. Most people are not developers, they just want to use
    > this driver.
    >
    > >  - I do not have this hardware so I can't test anything.
    > >
    > > So, from now on, I'm not taking ANYONES patches for this driver unless
    > > it gets an ack from the driver maintainer, Omar Luna.
    > >
    > > Actually, no, I'm not going to take any patch unless it _comes from_
    > > Omar.  Omar, please work to queue up patches and test them, and then
    > > send them to me for merging.
    > >
    > > Any questions?
    >
    > You mean after this pull, or should Omar re-send this pull request?

    I'm not pulling _anything_ at the moment for this driver.

    I want to see patches, not a pull request please, as these need to be
    reviewed very closely.

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-09 23:13    [W:0.027 / U:30.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site