Messages in this thread | | | Date | Tue, 9 Nov 2010 23:22:15 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] x86: fix apic.h unused but set warnings v2 |
| |
On Tue, Nov 09, 2010 at 02:50:51AM +0100, Andi Kleen wrote: > > Well, Andi I proposed to define variable as u64 and convert it back to u32 at procedure > > exit point. That would be clean, and I still think so ;) Though I'm fine with > > either way (I just thought about ones who will be reading this code in future, > > and since most the rdmsrl callers already use u64 and unsigned long, this would > > be consistent as well). > > I didn't use u64 because that would use more code on i386 > > -Andi
Fair enough. Thanks Andi.
Cyrill
| |