Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 9 Nov 2010 10:23:25 -0800 | Subject | Re: [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h |
| |
On Mon, Nov 8, 2010 at 9:38 PM, Joe Perches <joe@perches.com> wrote: > Move the logging bits from kernel.h into logging.h so that > there is a bit more logical separation of the generic from > the logging specific parts. > > Add pr_<level>_once macros to logging.h. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > include/linux/kernel.h | 246 +----------------------------------- > include/linux/logging.h | 322 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 324 insertions(+), 244 deletions(-) > create mode 100644 include/linux/logging.h
I detest patches like this.
The code movement makes it really hard to see what changed. So if you do code movement, please do _only_ code movement, and send a separate patch that actually changes things.
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |