Messages in this thread | | | Subject | Re: [PATCH v2] hwmon: (gpio-fan) Fix fan_ctrl_init error path | From | Guenter Roeck <> | Date | Tue, 9 Nov 2010 10:20:56 -0800 |
| |
On Tue, 2010-11-09 at 03:41 -0500, Axel Lin wrote: > In current implementation, the sysfs entries is not removed before return -ENODEV. > > Creating the sysfs attribute should be the last thing done by the function, > after all the rest has been successful. > Otherwise there is a small window during which user-space can access the attribute > but the driver isn't ready to deal with the requests. > > Fix it by moving sysfs_create_group to be the last thing done by the function. > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied.
Thanks, Guenter
| |