lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] hwmon: (gpio-fan) Fix fan_ctrl_init error path
From
Date
On Tue, 2010-11-09 at 03:41 -0500, Axel Lin wrote:
> In current implementation, the sysfs entries is not removed before return -ENODEV.
>
> Creating the sysfs attribute should be the last thing done by the function,
> after all the rest has been successful.
> Otherwise there is a small window during which user-space can access the attribute
> but the driver isn't ready to deal with the requests.
>
> Fix it by moving sysfs_create_group to be the last thing done by the function.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied.

Thanks,
Guenter




\
 
 \ /
  Last update: 2010-11-09 19:25    [W:0.041 / U:4.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site