Messages in this thread | | | Date | Tue, 09 Nov 2010 09:15:16 -0800 (PST) | Subject | Re: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net. | From | David Miller <> |
| |
From: xiaohui.xin@intel.com Date: Tue, 9 Nov 2010 17:03:05 +0800
> We provide an zero-copy method which driver side may get external > buffers to DMA. Here external means driver don't use kernel space > to allocate skb buffers. Currently the external buffer can be from > guest virtio-net driver.
1) Please use kernel-doc style comments to document structure members.
2) The idea to key off of skb->dev in skb_release_data() is fundamentally flawed since many actions can change skb->dev on you, which will end up causing a leak of your external data areas.
| |