lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 1/6] fs: icache RCU free inodes
    Date
    Nick Piggin <npiggin@kernel.dk> writes:

    > So here is the inode RCU code. It's obviously not worth doing until the
    > actual rcu-walk path walking is in, but I'd like to get opinions on it.
    > It would be nice to merge it in Al's tree at some point, though.

    I read the patch. It was quite monotonous (I guess that's a good thing)
    But it wasn't clear to me why you added the INIT_LIST_HEAD()s
    everywhere. Is this for stopping parallel walkers?

    Ok there's a comment in the doc: "VFS expects it to be initialized"
    Is that really true today? I don't think the old code does that.

    Other than that it seems straight forward.

    Reviewed-by: Andi Kleen <ak@linux.intel.com>

    -Andi

    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2010-11-09 15:21    [W:0.020 / U:4.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site