lkml.org 
[lkml]   [2010]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc
    On Wed, Oct 27, 2010 at 01:22:22PM -0700, Luben Tuikov wrote:
    > "Be conservative in what you send, liberal in what
    > you accept." -- In the spirit of this adage, don't
    > send Command IUs with randomly filled in data in
    > the reserved fields. (Yes, this shows up on the
    > wire.)

    Applied, with a better changelog entry ...

    > @@ -660,7 +660,7 @@ static int uas_probe(struct usb_interface *intf, const struct usb_device_id *id)
    > return -ENODEV;
    > }
    >
    > - devinfo = kmalloc(sizeof(struct uas_dev_info), GFP_KERNEL);
    > + devinfo = kzalloc(sizeof(struct uas_dev_info), GFP_KERNEL);
    > if (!devinfo)
    > return -ENOMEM;
    >

    Except for this hunk, which isn't an IU and doesn't go out on the wire.



    \
     
     \ /
      Last update: 2010-11-08 12:23    [W:3.604 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site