lkml.org 
[lkml]   [2010]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 00/23] netoops support
Date
Mike Waychison <mikew@google.com> writes:

I'm still not fully convinced this needs to be a fully separate
mechanism from netconsole. It seems a lot of work to implement
basically log level.

Maybe netconsole could be patched to support only dumping KERN_EMERG?

But I guess the structured logging has some advantages, although
there have been certainly oops parsers (e.g. kerneloops.org) without it.

> * I am _NOT_ happy with the remaining userland ABIs presented in this
> patchset. Specifically the files "net_dump_now",
> "net_dump_one_shot", "netdump_fw_version", "netdump_board_name"
> and

fw_version and board_name is known by the kernel anyways through the DMI
interface, assuming the BIOS supplies that. We also dump it already
on a standard oops. So why not just use that directly?

As a general user ABI perhaps simply an unstructured string is better
that is included in the packet.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2010-11-09 02:31    [from the cache]
©2003-2011 Jasper Spaans