Messages in this thread | | | Date | Mon, 8 Nov 2010 06:37:52 +0200 | From | Dan Carpenter <> | Subject | Re: [PATCH] ext4:memset is needless in ext4_ext_remove_space() |
| |
On Mon, Nov 08, 2010 at 09:19:47AM +0800, "潘卫平(Peter Pan)" wrote: > > memset is needless because path is allocated by kzalloc. >
This is inside a loop and sometimes we do i++ and sometimes i--. Are you absolutely positive that path + i isn't initialized?
I haven't followed this code through all the way but my instinct is that the memset is there for a reason.
regards, dan carpenter
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |