lkml.org 
[lkml]   [2010]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/16 v2] pramfs: super block operations
    Il 06/11/2010 12:16, James Hogan ha scritto:
    > Hi Marco,
    >
    > On Sat, Nov 06, 2010 at 09:56:39AM +0100, Marco Stornelli wrote:
    >> From: Marco Stornelli <marco.stornelli@gmail.com>
    >> +static void pram_set_blocksize(struct super_block *sb, unsigned long size)
    >> +{
    >> + int bits;
    >> +
    >> + /*
    >> + * We've already validated the user input and the value here must be
    >> + * between PRAM_MAX_BLOCK_SIZE and PRAM_MIN_BLOCK_SIZE
    >> + * and it must be a power of 2.
    >> + */
    >
    > Should this comment have spaces after the tabs to be consistent with the
    > other multiline comments (pram_ioremap) and the coding style?
    >

    Ok, no problem.

    Thanks for the review.

    Regards,

    Marco


    \
     
     \ /
      Last update: 2010-11-06 16:05    [W:0.022 / U:0.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site