Messages in this thread | | | Subject | RE: [PATCH] regulator: twl-regulator - fix twlreg_set_mode | From | Liam Girdwood <> | Date | Sat, 06 Nov 2010 11:54:45 +0000 |
| |
On Thu, 2010-11-04 at 15:08 +0530, Lesly Arackal Manuel wrote: > Forgot to mention- > > Only omap hsmmc driver is using regulator_set_mode() which will call > twlreg_set_mode(). > > > -----Original Message----- > > From: Lesly Arackal Manuel [mailto:leslyam@ti.com] > > Sent: Thursday, November 04, 2010 3:01 PM > > To: 'Nayak, Rajendra'; 'Liam Girdwood' > > Cc: 'Axel Lin'; 'linux-kernel'; 'Juha Keski-Saari'; 'Mark Brown' > > Subject: RE: [PATCH] regulator: twl-regulator - fix twlreg_set_mode > > > > > > I have tested it with MMC card inserted on OMAP3630SDP board (using OMAP3 > > integration tree). > > > > The changes seem to be valid. > > > > The i2c_transfer() returns '1' on success and the twl_i2c_write() which > > calls i2c_transfer returns '0' if success and err value if it fails. > > > > After writing the MSB if it returns with check: > > if (status >= 0) > > return status; > > It is not writing the LSB. > > > > So it should be: > > if (status < 0) > > return status; > > > > Regards, > > Lesly AM > >
Applied.
Thanks
Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
| |