lkml.org 
[lkml]   [2010]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] IDE: ide-floppy, remove unnecessary NULL check
    Date
    Stanse founf that rq in ide_floppy_callback cannot be NULL, because it
    is dereferenced all around. So remove the superfluous check.

    This appeared after blk_* macors removal.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: linux-ide@vger.kernel.org
    ---
    drivers/ide/ide-floppy.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
    index 5406b6e..536ff68 100644
    --- a/drivers/ide/ide-floppy.c
    +++ b/drivers/ide/ide-floppy.c
    @@ -73,7 +73,7 @@ static int ide_floppy_callback(ide_drive_t *drive, int dsc)
    drive->failed_pc = NULL;

    if (pc->c[0] == GPCMD_READ_10 || pc->c[0] == GPCMD_WRITE_10 ||
    - (rq && rq->cmd_type == REQ_TYPE_BLOCK_PC))
    + rq->cmd_type == REQ_TYPE_BLOCK_PC)
    uptodate = 1; /* FIXME */
    else if (pc->c[0] == GPCMD_REQUEST_SENSE) {

    --
    1.7.3.1



    \
     
     \ /
      Last update: 2010-11-06 10:11    [W:3.024 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site