[lkml]   [2010]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/4] udf: Replace bkl with a mutex for protect udf_inode_info struct
>  	struct inode vfs_inode;
> +
> + /* Serialize writer access, replace the old bkl */
> + struct mutex lock;

mentioning that it replaces bkl is not very useful for someone looking
at the code. Neither is "Seriazlize writer access". What would be
more useful is to document what exact fields are supposed to
be protected by this field. Take a look at hfsplus_inode_info, where
I documented the locking as part of the BKL removal during the 2.6.37

 \ /
  Last update: 2010-11-06 19:13    [W:0.072 / U:1.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site