Messages in this thread | | | Date | Fri, 05 Nov 2010 09:27:24 +0100 | From | Tejun Heo <> | Subject | Re: [PATCH] irq: use per_cpu kstat_irqs |
| |
On 11/04/2010 06:48 PM, Eric Dumazet wrote: > Use modern per_cpu API to increment {soft|hard}irq counters, and > use per_cpu allocation for (struct irq_desc)->kstats_irq instead of an > array. > > This gives better SMP/NUMA locality and saves few instructions per irq. > > With small nr_cpuids values (8 for example), kstats_irq was a small > array (less than L1_CACHE_BYTES), potentially source of false sharing. > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > Cc: Christoph Lameter <cl@linux-foundation.org> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Andi Kleen <andi@firstfloor.org> > Cc: Tejun Heo <tj@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de>
Looks good to me although it would be nice to note the white space fixes in the comment.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |