lkml.org 
[lkml]   [2010]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/7] fs/proc/base.c kernel/latencytop.c: Convert sprintf_symbol to %ps
    Date
    Use temporary lr for struct latency_record for improved readability
    and fewer columns used. Removed trailing space from output.

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    fs/proc/base.c | 22 ++++++++--------------
    kernel/latencytop.c | 23 +++++++++--------------
    2 files changed, 17 insertions(+), 28 deletions(-)

    diff --git a/fs/proc/base.c b/fs/proc/base.c
    index f3d02ca..1e0cbf4 100644
    --- a/fs/proc/base.c
    +++ b/fs/proc/base.c
    @@ -373,24 +373,18 @@ static int lstats_show_proc(struct seq_file *m, void *v)
    return -ESRCH;
    seq_puts(m, "Latency Top version : v0.1\n");
    for (i = 0; i < 32; i++) {
    - if (task->latency_record[i].backtrace[0]) {
    + struct latency_record *lr = &task->latency_record[i];
    + if (lr->backtrace[0]) {
    int q;
    - seq_printf(m, "%i %li %li ",
    - task->latency_record[i].count,
    - task->latency_record[i].time,
    - task->latency_record[i].max);
    + seq_printf(m, "%i %li %li",
    + lr->count, lr->time, lr->max);
    for (q = 0; q < LT_BACKTRACEDEPTH; q++) {
    - char sym[KSYM_SYMBOL_LEN];
    - char *c;
    - if (!task->latency_record[i].backtrace[q])
    + unsigned long bt = lr->backtrace[q];
    + if (!bt)
    break;
    - if (task->latency_record[i].backtrace[q] == ULONG_MAX)
    + if (bt == ULONG_MAX)
    break;
    - sprint_symbol(sym, task->latency_record[i].backtrace[q]);
    - c = strchr(sym, '+');
    - if (c)
    - *c = 0;
    - seq_printf(m, "%s ", sym);
    + seq_printf(m, " %ps", (void *)bt);
    }
    seq_printf(m, "\n");
    }
    diff --git a/kernel/latencytop.c b/kernel/latencytop.c
    index 877fb30..7cbbf5c 100644
    --- a/kernel/latencytop.c
    +++ b/kernel/latencytop.c
    @@ -242,24 +242,19 @@ static int lstats_show(struct seq_file *m, void *v)
    seq_puts(m, "Latency Top version : v0.1\n");

    for (i = 0; i < MAXLR; i++) {
    - if (latency_record[i].backtrace[0]) {
    + struct latency_record *lr = &latency_record[i];
    +
    + if (lr->backtrace[0]) {
    int q;
    - seq_printf(m, "%i %lu %lu ",
    - latency_record[i].count,
    - latency_record[i].time,
    - latency_record[i].max);
    + seq_printf(m, "%i %lu %lu",
    + lr->count, lr->time, lr->max);
    for (q = 0; q < LT_BACKTRACEDEPTH; q++) {
    - char sym[KSYM_SYMBOL_LEN];
    - char *c;
    - if (!latency_record[i].backtrace[q])
    + unsigned long bt = lr->backtrace[q];
    + if (!bt)
    break;
    - if (latency_record[i].backtrace[q] == ULONG_MAX)
    + if (bt == ULONG_MAX)
    break;
    - sprint_symbol(sym, latency_record[i].backtrace[q]);
    - c = strchr(sym, '+');
    - if (c)
    - *c = 0;
    - seq_printf(m, "%s ", sym);
    + seq_printf(m, " %ps", (void *)bt);
    }
    seq_printf(m, "\n");
    }
    --
    1.7.3.2.146.gca209


    \
     
     \ /
      Last update: 2010-11-06 00:17    [W:0.026 / U:60.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site